23w40a stuff #3682
Merged
23w40a stuff #3682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly block codec stuff
Shnupbups
added
new
ErrorCraft
suggested changes
Oct 4, 2023
There was a problem hiding this comment.
Would it make sense to treat decreaseStack and emptyStack as overloads of each other, as emptyStack calls the other one? How about removeStack or removeHeldStack as to not clash with the other removeStack(int) method?
It should also probably add the javadoc back that was removed from it.
YanisBft
reviewed
Oct 5, 2023
Co-authored-by: YanisBft <[email protected]>
apple502j
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just the block codec stuff